Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix drive section #1387

Merged
merged 2 commits into from
Aug 26, 2024
Merged

Conversation

joseivanlopez
Copy link
Contributor

@joseivanlopez joseivanlopez commented Aug 26, 2024

Problem

Agama calculates an AutoYaST proposal from a given JSON config file. Such a config file is a direct conversion from XML to JSON. This implies that some symbol attributes (e.g., type from drive section) are converted to string (JSON does not support symbols).

The AutoYaST proposal code works fine with strings instead of symbols, for example for the fileystem type, encryption method, etc. Except for the type attribute, which must be a symbol.

Solution

Ensure the type attribute is a symbol when importing a hash.

Required by agama-project/agama#1471.

@coveralls
Copy link

Coverage Status

coverage: 97.804%. remained the same
when pulling e4c97a9 on joseivanlopez:fix_drive_section
into 54c08ef on yast:master.

@joseivanlopez joseivanlopez marked this pull request as ready for review August 26, 2024 15:00
Copy link
Contributor

@ancorgs ancorgs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joseivanlopez joseivanlopez merged commit 5ca3c40 into yast:master Aug 26, 2024
7 checks passed
Copy link

✅ Autosubmission job #10562222369 successfully finished
✅ Created submit request #1196089

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants